Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DASH-444] Nebula - Update login flow #5750

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[DASH-444] Nebula - Update login flow #5750

merged 1 commit into from
Dec 16, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Dec 16, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on simplifying the chat and login components in the nebula-app, improving the handling of chat sessions, and refining the user interface for better usability.

Detailed summary

  • Added initialPrompt prop to ChatPageContent and related components.
  • Simplified EmptyStateChatPageContent by removing unnecessary props.
  • Introduced LoginAndOnboardingPageContent for login handling.
  • Refactored Chatbar and ChatPageContent to streamline state management and session handling.
  • Updated NebulaLoginPage to enhance login flow and UI interactions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear Linear
Copy link

linear bot commented Dec 16, 2024

DASH-444 Nebula chat UI implementation

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 8:26pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 16, 2024 8:26pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 16, 2024 8:26pm
wallet-ui ⬜️ Skipped (Inspect) Dec 16, 2024 8:26pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 16, 2024 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 16, 2024 18:42 Inactive
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7fc6191

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 16, 2024 18:42 Inactive
@MananTank MananTank marked this pull request as ready for review December 16, 2024 18:42
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 16, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Dec 16, 2024 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (b205280) to head (7fc6191).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5750   +/-   ##
=======================================
  Coverage   53.01%   53.01%           
=======================================
  Files        1101     1101           
  Lines       59079    59079           
  Branches     4806     4806           
=======================================
  Hits        31318    31318           
  Misses      27043    27043           
  Partials      718      718
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b205280
packages 50.14% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 2.7 s (-11.39% 🔽) 3.6 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 6 s (+9.36% 🔺) 8.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 389 ms (+30.22% 🔺) 500 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (+12.77% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 549 ms (+19.82% 🔺) 929 ms

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 16, 2024 •
edited
Loading

Merge activity

@MananTank
[DASH-444] Nebula - Update login flow (#5750)
7fc6191 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring and updating the chat and login components in the `nebula-app`, enhancing the handling of chat sessions, prompts, and user interactions.

### Detailed summary
- Added `initialPrompt` to `ChatPageContent` and `EmptyStateChatPageContent`.
- Simplified `EmptyStateChatPageContent` props.
- Introduced `LoginAndOnboardingPageContent` for better login handling.
- Updated `NebulaLogin` to use `NebulaLoginPage`.
- Refactored message handling and session management in `ChatPageContent`.
- Removed unnecessary props in `Chatbar` and `EmptyStateChatPageContent`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-17-_dash-444_nebula_-_update_login_flow branch from e427814 to 7fc6191 Compare December 16, 2024 20:18
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 16, 2024 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 16, 2024 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 16, 2024 20:18 Inactive
@graphite-app graphite-app bot merged commit 7fc6191 into main Dec 16, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-17-_dash-444_nebula_-_update_login_flow branch December 16, 2024 20:27
@vercel vercel bot temporarily deployed to Production – docs-v2 December 16, 2024 20:27 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 16, 2024 20:27 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 16, 2024 20:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

@jakubkrehel jakubkrehel Awaiting requested review from jakubkrehel jakubkrehel is a code owner

Assignees

@MananTank MananTank

Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MananTank @jnsdls